分享下我写不需要太严谨的项目的代码风格

public static Common.DB.ResultList GetList(Common.DB.NVCollection queryParams)
{

//string pageString = queryParams["page"] as string ?? "1";
//string psString = queryParams["pagesize"] as string ?? string.Empty;
//string cidString = queryParams["cid"] as string ?? string.Empty;

string sort = queryParams["sort"] as string ?? string.Empty;
string cate = queryParams["cate"] as string ?? string.Empty;
string type = queryParams["type"] as string ?? string.Empty;
string ch = queryParams["ch"] as string ?? string.Empty;
string kind = queryParams["kind"] as string ?? string.Empty;

string andwhere = "1=1";
string rootKey = null;
switch (type)
{
case "appsoft":
rootKey = "iphones";
break;
case "appgame":
rootKey = "iphoneg";
break;
case "azsoft":
rootKey = "soft";
break;
case "azgame":
rootKey = "game";
break;
}

var pnvc = new Common.DB.NVCollection();

if (rootKey != null)
{
var pcate = DBCache.SoftCategoryCache.Get(rootKey);
if (pcate != null)
{
andwhere += " and charIndex(@path,categoryPath)>0 ";
pnvc["path"] = "/" + pcate.ID + "/";
}
}

if (ch == "az")
{
andwhere += " and (charIndex(@path1,categoryPath)>0 or charIndex(@path2,categoryPath)>0)";
pnvc["path1"] = "/" + DBCache.SoftCategoryCache.Get("game").ID + "/";
pnvc["path2"] = "/" + DBCache.SoftCategoryCache.Get("soft").ID + "/";
}
else if (ch == "app")
{
andwhere += " and (charIndex(@path1,categoryPath)>0 or charIndex(@path2,categoryPath)>0)";
pnvc["path1"] = "/" + DBCache.SoftCategoryCache.Get("appgame").ID + "/";
pnvc["path2"] = "/" + DBCache.SoftCategoryCache.Get("appsoft").ID + "/";
}

if (!string.IsNullOrEmpty(cate) && !string.IsNullOrEmpty(rootKey))
{
var cateEnt = DBCache.SoftCategoryCache.Get(rootKey, cate);

if (cateEnt != null)
{
andwhere += " and categoryid=@cid ";
pnvc["cid"] = cateEnt.ID;
}
}

int cid = (queryParams["cid"] as int?) ?? 0;
if (cid > 0)
{
var cateEnt = DBCache.SoftCategoryCache.Get(cid);

if (cateEnt != null)
{
andwhere += " and categoryid=@cid ";
pnvc["cid"] = cateEnt.ID;
}
}

string orderby = " id desc";
switch (sort)
{
case "new":
orderby = " id desc";
break;
case "hot":
orderby = " viewTimes desc,id desc";
break;
case "rank":
orderby = " downWeekTimes desc,id desc";

break;
default:
break;
}

switch (kind)
{
case "number":
andwhere += " and number>0";
orderby = " number desc,id desc ";
break;
case "hprec":
andwhere += " and recommend=1 and homepage=1 and number=0 ";
orderby = " viewtimes desc,id desc ";
break;
case "recnothp":
andwhere += " and recommend=1 and homepage=0 and number=0 ";
orderby = " viewtimes desc,id desc ";
break;
case "rec":
andwhere += " and recommend=1 ";
break;

case "all":

break;

case "normal":
default:
andwhere += " and recommend=0 and homepage=0 and number=0 ";
//orderby = " id desc ";
break;
}

int page = (queryParams["page"] as int?) ?? 1;
if (page <= 0)
{
page = 1;
}

int pagesize = (queryParams["pagesize"] as int?) ?? 10;

if (pagesize <= 0)
{
pagesize = 10;
}

Common.DB.ResultList result = new Common.DB.ResultList(pagesize);

var dbh = Common.DB.Factory.Default;

//List<Common.DB.NVCollection> list = new List<Common.DB.NVCollection>(pagesize);

var query = Common.DB.Factory.DefaultPagerQuery;
query.AbsolutePage = page;
query.Fields = "id,name,version,viewtimes,categoryid";
query.PageSize = pagesize;
query.Sort = orderby;
query.Table = "soft";
query.Where = andwhere;

string csql = query.GetCountQueryString();
string qsql = query.GetQueryString();

int rc = dbh.ExecuteScalar<int>(csql, pnvc);
var ls = dbh.GetDataList(qsql, pnvc);

int pc = Convert.ToInt32(Math.Ceiling((decimal)rc / (decimal)pagesize));

result.Page = page;
result.PageCount = pc;
result.RecordCount = rc;
result.PageSize = pagesize;

for (int i = 0; i < ls.Count; i++)
{
var o = ls[i];

var ent = new Common.DB.NVCollection();
var entcate = DBCache.SoftCategoryCache.Get((int)o["categoryid"]);

ent["id"] = o["id"];
ent["name"] = o["name"];
ent["version"] = o["version"];
ent["cid"] = o["categoryid"];
ent["cpath"] = Services.PathService.GetListPath(entcate);
ent["cname"] = entcate.Name;
ent["path"] = Services.PathService.GetPath(entcate, (int)o["id"]);
ent["dtimes"] = o["viewtimes"];

result.Add(ent);
}

return result;
}

dbfox

2015-11-20 09:30:10 +08:00

@lawrencexu
@jarlyyn
@lawrencexu
@longaiwp
@wizardforcel

可能我表达的不够清楚还是不要管我内部怎么实现了，主要是在方法的参数上

如果是以前，我会这样定义方法：

public static Common.DB.ResultList GetList(int page,int pagesize,string sort,string type,....)

调用的时候，大家应该都知道，要进行繁琐的类型转换 int.Parse()

需求一旦一改，增加一个参数或者改变一个参数，函数就被破坏掉了，或者要追加一个方法，同时要改变方法内部的实现

public static Common.DB.ResultList GetList(int page,int pagesize,int cid,string sort,string type,....)

后来我想可以增加一个参数类
如

public class QueryParams
{
public int Page{get;set;}
public int PageSize{get;set;}
public string Sort{get;set;}
public int Cid{get;set;}
}

这时候方法就变成这样：
public static Common.DB.ResultList GetList(queryParams Query);

增加参数，减少参数，都可以通过修改 QueryParams 的属性和方法内部实现，而不用破坏方法对外的改变

再后来，我发现这样还是比较繁琐，写得太严谨，反而很费时

干脆把参数变更为和 PHP 相似的 key-object 弱类型，返回值也是弱类型，这样开发效率高了很多倍

在外部传入参数的时候
KeyObjectCollection kvc = new KeyObjectCollection();
kvc["page"] = int.Parse(接收到传输过来的 Page);//这里是已经经过转换的，所以不用担心注入

public static KeyObjectResultList GetList(KeyObjectCollection query){

int page = query["page"] as int; //把 object 类型拆箱，为 int 类型

}

我发现这样更灵活，更方便，这里我本来不想讨论我 sql 拼接，我之前也用过一些框架 entity framework 等，觉得真的不好用，而且我懒得深入学习这些东西，性能和开发效率还有项目的灵活性，都不太容易掌控，所以我不愿意去用，我当然能体会到一些 orm 的好处，但是带来的一些诟病也不少，不如直接我什么都不想，直接拼 sql 好了，诸位大神，也可以说说，你们怎么写的，顺便学习学习。

我追求的东西其实也很简单：就是 - “简”，
只有把项目尽可能做到非常简单，依赖的东西非常少，项目才省心。
就像象棋，很少的规则，可以玩得很有意思。